Inline propTypes checking code #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The propTypes checking contract hasn't changed for years. It's stable.
Its source of truth lives in the prop-types package. However, we are inlining it in the React repo (facebook/react#18127) to simplify React's ES Modules adoption story. We will do the same with the Object.assign polyfill. This PR mirrors the same change for the shallow renderer, too.
The goal is to get to a place where none of our transitive dependencies require CommonJS for bundling.
The other change here is that I reuse the existing React's mechanism for injecting the stack. Previously, shallow renderer did a special thing, which only worked for propTypes. Now we use a generic mechanism so if you call, for example,
React.createElement, it will also get the right stack.Easier to review without whitespace: https://github.com/NMinhNguyen/react-shallow-renderer/compare/inline-pt?w=1