Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-shallow-renderer from 16.12.0 to 16.13.0 #18185

Merged

Conversation

NMinhNguyen
Copy link
Contributor

@NMinhNguyen NMinhNguyen commented Feb 28, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad810a8:

Sandbox Source
floral-framework-y4fxv Configuration

@sizebot
Copy link

sizebot commented Feb 28, 2020

Details of bundled changes.

Comparing: 26aa198...ad810a8

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js 0.0% -0.0% 552.1 KB 552.1 KB 116.54 KB 116.54 KB FB_WWW_DEV
react-test-renderer-shallow.development.js -2.9% -2.1% 39.53 KB 38.39 KB 9.48 KB 9.29 KB UMD_DEV
react-test-renderer-shallow.production.min.js 🔺+0.2% 🔺+0.2% 12.88 KB 12.91 KB 3.93 KB 3.93 KB UMD_PROD
react-test-renderer.development.js 0.0% -0.0% 550.93 KB 550.93 KB 114.74 KB 114.74 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.1 KB 71.1 KB 21.61 KB 21.6 KB UMD_PROD
react-test-renderer.development.js 0.0% -0.0% 525.06 KB 525.06 KB 113.39 KB 113.39 KB NODE_DEV

Size changes (stable)

Generated by 🚫 dangerJS against ad810a8

@sizebot
Copy link

sizebot commented Feb 28, 2020

Details of bundled changes.

Comparing: 26aa198...ad810a8

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js 0.0% -0.0% 552.11 KB 552.11 KB 116.54 KB 116.54 KB FB_WWW_DEV
react-test-renderer-shallow.development.js -2.9% -2.1% 39.55 KB 38.4 KB 9.49 KB 9.3 KB UMD_DEV
react-test-renderer-shallow.production.min.js 🔺+0.2% 🔺+0.2% 12.9 KB 12.92 KB 3.93 KB 3.94 KB UMD_PROD
react-test-renderer.development.js 0.0% -0.0% 550.96 KB 550.96 KB 114.75 KB 114.75 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.12 KB 71.12 KB 21.62 KB 21.62 KB UMD_PROD
react-test-renderer.development.js 0.0% -0.0% 525.09 KB 525.09 KB 113.4 KB 113.4 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 70.94 KB 70.94 KB 21.31 KB 21.3 KB NODE_PROD

Size changes (experimental)

Generated by 🚫 dangerJS against ad810a8

react-shallow-renderer@^16.13.0:
version "16.13.0"
resolved "https://registry.yarnpkg.com/react-shallow-renderer/-/react-shallow-renderer-16.13.0.tgz#18defe59ac922a9623fcbb8bed8db0da7c728fd4"
integrity sha512-qdFKyjjHSp5t4+Fs4479JqYDQnBdHi/IZEnGEmZZKZqoiwxjG4DKJPYd7YTaTmalUAqZlZR+K9ayz1+8tEctSg==
dependencies:
object-assign "^4.1.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebmarkbage I saw your comment (#18127 (review)) about it being good to remove prop-types (CJS dep). Should I also inline an ES version of object-assign?

@sebmarkbage sebmarkbage merged commit c26506a into facebook:master Feb 29, 2020
@NMinhNguyen NMinhNguyen deleted the react-shallow-renderer-16.13.0 branch February 29, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants