Add cutomizable timer duration

[pakaoraki]

Add new "Timer" menu in preferences with customizable timer duration.

This will close #296

[pakaoraki]

It look like there is some issues with my code, I can't fix PR right now, I will have more time tomorrow evening. Cheers

[stuarthayhurst]

I haven't looked at the code yet, but would it be better to store timer lengths using 1 key as an array, instead of 3 separate keys?

Also, if I remember correctly, red is supposed to be for destructive actions according to the GNOME Human Interface Guidelines I think it was? I don't know if that applies to extensions, but it might be worth considering to be consistent with the rest of GNOME.

Still, this is a clear improvement over the current system, nice work :)

[pakaoraki]

I haven't looked at the code yet, but would it be better to store timer lengths using 1 key as an array, instead of 3 separate keys?

Yes I totally agree, I was thinking the same. I just used a simple 'int' type for each duration but it need to be unified with a single key.

Also, if I remember correctly, red is supposed to be for destructive actions according to the GNOME Human Interface Guidelines I think it was? I don't know if that applies to extensions, but it might be worth considering to be consistent with the rest of GNOME.

It make sense, I hesitated to keep the red color anyway so I can remove it.

There are some other small improvements to make, I'll try to fix it all this evening or tomorrow for final review.

[pakaoraki]

There is a weird eslint issue:

/home/runner/work/gnome-shell-extension-caffeine/gnome-shell-extension-caffeine/caffeine@patapon.info/preferences/timerPage.js
283:13 error Expected property shorthand object-shorthand

The code is the same as line 66, but it cause an error only in line 283. Should I ignore this using /* eslint-disable object-shorthand */ and /* eslint-enable object-shorthand */ or did I miss something ?

[stuarthayhurst]

There is a weird eslint issue:

/home/runner/work/gnome-shell-extension-caffeine/gnome-shell-extension-caffeine/caffeine@patapon.info/preferences/timerPage.js
283:13 error Expected property shorthand object-shorthand

The code is the same as line 66, but it cause an error only in line 283. Should I ignore this using /* eslint-disable object-shorthand */ and /* eslint-enable object-shorthand */ or did I miss something ?

I think it's because the variables have different names, durationIndex and value. I think changing the name of value, or replacing value: value with value should do it?

[pakaoraki]

Thanks

[gabrbrand]

I manually installed this branch with make all on Fedora Rawhide (Gnome 46).
The stopwatch-symbolic currently isn't visible in dark style:

This can be fixed by moving caffeine@patapon.info/icons/stopwatch-symbolic.svg to caffeine@patapon.info/icons/hicolor/scalable/actions and changing

Gio.icon_new_for_string(`${this._path}/icons/${TimerMenuIcon}.svg`); 

to

Gio.icon_new_for_string(`${this._path}/icons/hicolor/scalable/actions/${TimerMenuIcon}.svg`);

in caffeine@patapon.info/extension.js (line 147)

[pakaoraki]

Thanks for reporting, icon fixed. Tested in Ubuntu 24.04 / Fedora 40.

[stuarthayhurst]

The pipeline failure seems to be eslint 9 complaining about arguments, we wouldn't need to try and fix it if we just drop the jsdoc stuff, since I don't think we don't really use it anyway

If we drop it we just need to update the makefile, workflow definition and linter configs

[pakaoraki]

I tried to remove the jsdoc plugin but it's seams that we need to rewrite the entire Eslint config for version 9.0 (migrate-to-9.0.0) as they changed the config file format.

Should we make a separate PR for this ?

[stuarthayhurst]

Should we make a separate PR for this ?

Yeah, probably a good idea

[matdave]

This feature is awesome. I've been wanting long timers since I work on dual computers and need both on during my work day. This is saving me from having to remember to turn caffeine off at the end of my work day.

[pakaoraki]

@eonpatapon @stuarthayhurst
I think it's ready to merge, let me know if it's ok for you.

[stuarthayhurst]

Looks ok to me, do we want to merge this with a squash merge since there are a lot of small commits and fixes for previous commits?

[stuarthayhurst]

Just a heads up, the locales don't need to be updated with every change if it's just line numbers that changed, it also makes reverting commits harder

I can't see anything else to change, LGTM. I'll rebase #334 when this is merged.

[stuarthayhurst]

This doesn't seem right, hours shouldn't be plural here (also applies when set to 1 minute).

[pakaoraki]

This doesn't seem right, hours shouldn't be plural here (also applies when set to 1 minute).

I fix it: it will display properly the plural only when it should. I also improve the code as you suggest. Let me know if you see somethings else.

[pakaoraki]

Just a heads up, the locales don't need to be updated with every change if it's just line numbers that changed, it also makes reverting commits harder

I can't see anything else to change, LGTM. I'll rebase #334 when this is merged.

Ok I will stop doing that, it's also make it easiest. Then, is translation reference update when installing the extension ?

[stuarthayhurst]

Just a heads up, the locales don't need to be updated with every change if it's just line numbers that changed, it also makes reverting commits harder
I can't see anything else to change, LGTM. I'll rebase #334 when this is merged.

Ok I will stop doing that, it's also make it easiest. Then, is translation reference update when installing the extension ?

Whoops, I missed the lines that did actually change in those commits, sorry. For my own extensions, I update the translations when a feature is completely ready since I find that simpler.

[stuarthayhurst]

I'll run this for a couple days and let you know if anything goes wrong, otherwise it's looking good :)

[foolishgrunt]

Super stoked to see this feature added! Any idea when we'll see a new release?

[stuarthayhurst]

Super stoked to see this feature added! Any idea when we'll see a new release?

Most likely with the release to add GNOME 47 support, which should be around September time. In the meantime, you could always build from source, you'll just have to increase the version number to match the current release, otherwise GNOME will 'update' it.