Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive logging of P2P handshake messages #790

Closed
heifner opened this issue Aug 8, 2022 · 0 comments · Fixed by #798
Closed

Excessive logging of P2P handshake messages #790

heifner opened this issue Aug 8, 2022 · 0 comments · Fixed by #798
Assignees
@heifner
Labels
OCI OCI working this issue...
Milestone
Mandel 3.1.0-rc4

Comments

@heifner
Copy link
Member

heifner commented Aug 8, 2022

Testing of v3.1.0-rc3 on Jungle.

Reports of excessive log entries:

net_plugin.cpp:1828           recv_handshake       ] ["tf-eos-jungle4-bp-api2:9876 - a25bf2e" - 9 87.98.174.35:9876] handshake lib 1605797, head 1606133, head id 4a7b86ab695a0669.. sync 2
@heifner heifner added this to the Mandel 3.1.0 milestone Aug 8, 2022
@heifner heifner moved this to Todo in ENF Engineering Aug 8, 2022
@heifner heifner self-assigned this Aug 8, 2022
@heifner heifner added the OCI OCI working this issue... label Aug 8, 2022
heifner added a commit that referenced this issue Aug 8, 2022
@heifner
GH-790 In the case the full block log is not available, prevent hands…
a9d7004 
…hake message being sent sync-fetch count times to peer. For example, if the client requested 1000 blocks not available by the node, net_plugin would respond with 1000 handshake messages. Disconnect from peer with benign_other so the peer will move on to a different peer to sync from. This is what we already do for blk_send_branch when a block is not available.
@heifner heifner mentioned this issue Aug 8, 2022
Merged
@heifner heifner modified the milestones: Mandel 3.2.0, Mandel 3.1.0 Aug 9, 2022
heifner added a commit that referenced this issue Aug 9, 2022
@heifner
Merge pull request #791 from eosnetworkfoundation/GH-790-handshake-ms…
74fc8e6 
…gs-3.1

[3.1] Reduce net_plugin handshake messages in case of unavailable blocks
heifner added a commit that referenced this issue Aug 9, 2022
@heifner
Merge remote-tracking branch 'origin/release/3.1.x' into GH-790-hands…
df8665c 
…hake-msgs
@heifner heifner mentioned this issue Aug 9, 2022
Merged
heifner added a commit that referenced this issue Aug 10, 2022
@heifner
Merge pull request #798 from eosnetworkfoundation/GH-790-handshake-msgs
359e98c 
[3.1 -> main] Reduce net_plugin handshake messages in case of unavailable blocks
Repository owner moved this from Todo to Done in ENF Engineering Aug 10, 2022
@chillsauce chillsauce mentioned this issue Aug 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
OCI OCI working this issue...
Projects
ENF Engineering
Status: Done
Milestone
Mandel 3.1.0-rc4
2 participants
@heifner @stephenpdeos