Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] Reduce net_plugin handshake messages in case of unavailable blocks #791

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

heifner
Copy link
Member

@heifner heifner commented Aug 8, 2022

In the case the full block log is not available, prevent handshake message being sent sync-fetch count times to peer. For example, if the client requested 1000 blocks not available by the node, net_plugin would respond with 1000 handshake messages. Disconnect from peer with benign_other so the peer will move on to a different peer to sync from. This is what we already do for blk_send_branch when a block is not available.

Resolves #790

…hake message being sent sync-fetch count times to peer. For example, if the client requested 1000 blocks not available by the node, net_plugin would respond with 1000 handshake messages. Disconnect from peer with benign_other so the peer will move on to a different peer to sync from. This is what we already do for blk_send_branch when a block is not available.
@heifner heifner added the OCI OCI working this issue... label Aug 8, 2022
@oschwaldp-oci oschwaldp-oci self-requested a review August 9, 2022 17:12
@heifner heifner merged commit 74fc8e6 into release/3.1.x Aug 9, 2022
@heifner heifner deleted the GH-790-handshake-msgs-3.1 branch August 9, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCI OCI working this issue...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants