Add the State set_timestamp function #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As we can see, the python bindings need more attention. I remember that I faced the same issue when I was refactoring tests a few weeks back. We need to decide which time module to use in python and then explicitely bind that to the cpp type. Not 100% sure how to do that though. |
|
https://pybind11.readthedocs.io/en/stable/advanced/cast/chrono.html The C++ timestamp binds to |
domire8
requested changes
Oct 18, 2021
Co-authored-by: domire8 <71256590+domire8@users.noreply.github.com>
…libraries into feature/set-timestamp
|
Thanks both for checking and correcting, This should be good now |
domire8
previously approved these changes
Oct 18, 2021
* Specify nanosecond count since epoch as the integer timestamp representation in state.proto * Add an explicit duration type of nanoseconds to clproto header * Set the timestamp when decoding a message into a State
domire8
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
set_timestampfunction inStatewhich I would like to use downstream when receiving timed messages. Also, I have realized thetimestampuses asteady_clockwhich is different to howroshandles time (those would besystem_clock). I think this is still acceptable as we can convert between the two. But we have to acknowledge that properly.