Set timestamp when decoding message #219
Merged
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Specify nanosecond count since epoch as the integer timestamp representation in state.proto * Add an explicit duration type of nanoseconds to clproto header * Set the timestamp when decoding a message into a State
eeberhard
force-pushed
the
feature/set-timestamp-proto
branch
from
0cda424 to
3982520
Compare
|
I think this should be a part of #218 in order to resolve my old TODO at the same time. While the python test is unsuccessful because of the base branch, the protocol test passes in the CI. |
buschbapti
approved these changes
Oct 18, 2021
buschbapti
added a commit
that referenced
this pull request
Oct 18, 2021
* feat: add the setter for the state timestamp attribute * feat: add the python bindings for the set_timestamp function * fix: update changelog * fix: correct the binding to the time module Co-authored-by: domire8 <71256590+domire8@users.noreply.github.com> * fix: add the `set_timestamp` function in the list of expected functions * fix: add missing import * Set timestamp when decoding message (#219) * Specify nanosecond count since epoch as the integer timestamp representation in state.proto * Add an explicit duration type of nanoseconds to clproto header * Set the timestamp when decoding a message into a State Co-authored-by: domire8 <71256590+domire8@users.noreply.github.com> Co-authored-by: Enrico Eberhard <32450951+eeberhard@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify nanosecond count since epoch as the integer timestamp
representation in state.proto
Add an explicit duration type of nanoseconds to clproto header
Set the timestamp when decoding a message into a State