Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent behavior for VaTimeInput right icon #3922

Closed
asvae opened this issue Sep 27, 2023 · 3 comments · Fixed by #3933
Closed

Inconsistent behavior for VaTimeInput right icon #3922

asvae opened this issue Sep 27, 2023 · 3 comments · Fixed by #3933
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. v1: minor This might be helpful, but not really

Comments

@asvae
Copy link
Member

asvae commented Sep 27, 2023

Vuestic-ui version: 1.8.0

When you click on icon - dropdown doesn't close
When you click on input - dropdown closes

Icon should not have different behavior, it should behave as if it doesn't exist (I believe), and you only have input.

image

Compare to
https://www.naiveui.com/en-US/os-theme/components/time-picker
@asvae asvae added BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. v1: minor This might be helpful, but not really labels Sep 27, 2023
@Udaay
Copy link
Contributor

Udaay commented Oct 1, 2023

@asvae Picking this up

@Udaay
Copy link
Contributor

Udaay commented Oct 1, 2023

Hi @asvae have gone through naiveUI time picker component.
DropDown only closes when only on focusOut from InputBox.

Currently Implementing the same , dropdown will not close onclick on inputBox & Icon.

@Udaay
Copy link
Contributor

Udaay commented Oct 1, 2023

#3933

@asvae asvae mentioned this issue Oct 1, 2023
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Backlog to Done in Vuestic Dashboard Oct 12, 2023
m0ksem pushed a commit that referenced this issue Oct 12, 2023
@Udaay
Inconsistent behavior for VaTimeInput right icon #3922 (#3933)
080b053 
* fix: replaced toggleDropdown with showDropdown

* fix: removed console

* fix: showDropdown on icon click

* fix: unrelated changes

* fix: prettier changes

* fix: removed unused variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BUG Something isn't working d1: super easy Task for newbies. Players take half normal damage from monsters and the environment. v1: minor This might be helpful, but not really
Projects
Vuestic Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inconsistent behavior for VaTimeInput right icon #3922 Udaay/vuestic-ui
2 participants
@asvae @Udaay