Inconsistent behavior for VaTimeInput right icon #3922 #3933
Conversation
Udaay
changed the title
|
Hey. I was mistaken to reference naive ui. Instead I should've mentioned vuestic-ui select. https://ui-storybook-develop.vuestic.dev/?path=/story/vaselect--old-demos Naive does not close elements on click. But vuestic does. So we need to have toggle behavior for both icon and wrapper.
|
|
Yeah that will do the trick, I will make changes. |
| @@ -407,4 +401,8 @@ export default defineComponent({ | |||
|
|
|||
| <style lang="scss"> | |||
| @import "variables"; | |||
|
|
|||
| .va-time-input__side-button { | |||
| pointer-events: var(--va-time-input-side-button-pointer-events); | |||
There was a problem hiding this comment.
Hey, @Udaay. We use CSS variables, so it is easier for user to change component look. Do you think there is a case when user need to change pointer-events behavior?
The perfect examples of using css variables to configure border-radius, border-width, paddings, margins, etc.
What I don't like is to have css variables, that for 99% will not be changed. Like display (which is set to flex and whole component breaks if display is changed), position (which must be relative otherwise everything breaks).
We actually do not follow this rule completely, we have a lot of old stuff which was converted to css variables by a script. And I hope in future we will have less meaningless variables.
If you find pointer-events css variable helpful here, let's have it, but if not please remove the css variable. Thanks.
There was a problem hiding this comment.
Yes , I got your point and whole idea behind the css variables so that user can configure some specific styles.
Will remove this variable and add directly.
| @@ -1,4 +1,5 @@ | |||
| :root, | |||
| :host { | |||
| --va-time-input-min-width: var(--va-form-element-min-width); | |||
There was a problem hiding this comment.
I'm also not sure if --va-time-input-min-width is used somewhere, so this can be removed too likely.
There was a problem hiding this comment.
let me check, I will remove it if it doesn't required.
close #3922
Description
Changed the onClick handler of
va-input-wrapperTypes of changes