Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 21: fix typo in theme, add nav bar structure #22

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

kaitejohnson
Copy link
Collaborator

@kaitejohnson kaitejohnson commented Feb 4, 2025

Description

This PR closes #21. It fixes the typo in the _pkgdown.yaml that was preventing the enw_theme() from working and adds the formatting to the navigation bar.

For a separate issue, but we could add a preview of the site as a comment to the PR? I downloaded the artifact but either the theme still isn't working (possible) or the formatting doesn't seem to display

Tangentially related to formatting, I think I should make an issue to add back in the wordlist and spelling?

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@kaitejohnson kaitejohnson marked this pull request as ready for review February 4, 2025 11:36
@kaitejohnson kaitejohnson marked this pull request as draft February 4, 2025 11:36
@kaitejohnson kaitejohnson marked this pull request as ready for review February 4, 2025 12:01
@kaitejohnson kaitejohnson requested a review from seabbs February 5, 2025 14:26
Copy link
Collaborator

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to be merged. I agree it makes sense to make a new issue to look at adding a preview - ideally that work would be done as a epinowcast action so we can use it elsewhere. We may also want a new issue to add more yaml structure and in particular a structured reference to closer match other epinowcast projects: https://github.com/epinowcast/primarycensored/blob/cb9017d39f57906350ba22522862bb2559332166/_pkgdown.yml#L10

@kaitejohnson
Copy link
Collaborator Author

Yes was thinking the same thing about the structured references -- will make a new issue to brainstorm what we would want these to be (if we want them).

Will also make an issue about the comment preview. I agree it would be a good thing to have in epinowcast, but also would want something probably very similar to the CDCgov action...

@kaitejohnson kaitejohnson merged commit 760886a into main Feb 6, 2025
7 checks passed
@kaitejohnson kaitejohnson deleted the 21-fix-site branch February 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix website formatting
2 participants