generated from epiverse-trace/packagetemplate
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug age risk #44
Merged
Merged
Bug age risk #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function now checks that if `gender` info is provided it has the same number of elements as `age`
The plot argument in the helping function `graphics::hist` has to be FALSE to avoid attempts of displaying data
The function now can handle the case when users have a populatio_pyramid dissagreggated by gender but still want to estimate an age_risk distribution where genders are aggregated
Juanmontenegro99
added a commit
that referenced
this pull request
Oct 13, 2023
* Create test-endemic_channel * Tests endemic channel (#25) * #23 create endemic channel test * #23 update endemic channel assertions * Update documentation * Update lint * Uptade lint * Update lint * Update README.md (#27) * 24 fix incidence historic length handling (#28) * #24 verify incidence and observations * #24 Verify length of the incidence historic * #24 adding warnings and final tests * Fix warnings * Fix unused variable * 26 modify moran index function (#29) * #26 modified function and test * Revert "#26 modified function and test" This reverts commit 52f24b0. * #26 modified function and test * Update lint * Fix lint * 8 demographics vignette (#32) * Vignette creation * Update demographics-vignette.Rmd * Update demographics-vignette.Rmd * Actualizar demographics-vignette.Rmd * Actualizar demographics-vignette.Rmd * Update demographics-vignette.Rmd * Update demographics-vignette.Rmd * Update demographics-vignette.Rmd * Update of vignette format * 30 population pyramids age ranges (#31) * 24 fix incidence historic length handling (#28) * #24 verify incidence and observations * #24 Verify length of the incidence historic * #24 adding warnings and final tests * Fix warnings * Fix unused variable * 26 modify moran index function (#29) * #26 modified function and test * Revert "#26 modified function and test" This reverts commit 52f24b0. * #26 modified function and test * Update lint * Fix lint * Update demographics.R * Age ranges feature Include the feature to customize the age ranges for the population pyramids and specific age rates * Update * Create detect_outbreaks_ewma.Rd --------- Co-authored-by: Juan Montenegro Torres <60274234+Juanmontenegro99@users.noreply.github.com> * Update demographic_vignette.Rmd * Update demographic_vignette.Rmd --------- Co-authored-by: Juan Montenegro Torres <60274234+Juanmontenegro99@users.noreply.github.com> * Create endemic_channel.Rmd * Create endemic_channel_figure.png Figure for the endemic channel vignette * Update logo New epiCo logo * Update README * Update endemic_channel.Rmd * Style updates * Restore dependency on R 3.2.0 because of anyNA() * Spatiotemporal vignette (#37) * Create spatiotemporal_vignette.Rmd * Fix vignettes * Fix lint errors * Fix styler * Temporal fix lint * upload data * Update tests and fix age range parameter (#35) * Update tests and fix age range parameter * Create project and fix concatenation_linter * Update vignettes with the new data * #40 * fix warnings lint * Fix lint warnings * fix warnings * Delete unnecessary files * Fix lint warnings * Delete commented code --------- Co-authored-by: Juan Montenegro Torres <60274234+Juanmontenegro99@users.noreply.github.com> * 41 fix path bug (#42) Relocate data and fix #41. * update moran's example * Fix bug in morans_index map Now morans_index function returns a list with the data and the leaflet map that can be displayed later * Bug age risk (#44) * Add error handling age_risk Function now checks that if `gender` info is provided it has the same number of elements as `age` * Fix age_risk bug The plot argument in the helping function `graphics::hist` has to be FALSE to avoid attempts of displaying data * Fix age_risk bug The function now can handle the case when users have a populatio_pyramid dissagreggated by gender but still want to estimate an age_risk distribution where genders are aggregated * Style fix * Delete unnecessary files * Update test-demographics.R (#47) * Handle warnings * Documentation and style changes * style and documentation changes * fix lint warnings --------- Co-authored-by: juan-umana <jd.umana10@uniandes.edu.co> Co-authored-by: Juan D. Umaña <juan.umanacaro@gmail.com> Co-authored-by: Juanmontenegro99 <jf.montenegro@uniandes.edu.co> Co-authored-by: Hugo Gruson <Bisaloo@users.noreply.github.com> Co-authored-by: Julian Otero <56242573+jd-otero@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fix bug reported in #43 reported by @Juanmontenegro99
age_risk function can handle gender-aggregated estimations even when the population_pyramid argument has gender-disaggregated data