Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding Language: en-GB to DESCRIPTION #103

Closed
bahadzie opened this issue Nov 21, 2023 · 1 comment · Fixed by #105
Closed

Consider adding Language: en-GB to DESCRIPTION #103

bahadzie opened this issue Nov 21, 2023 · 1 comment · Fixed by #105

Comments

@bahadzie
Copy link
Member

Running spell check by default uses en-US and flags words spelt in en-GB. After adding Language: en-GB to DESCRIPTION these lines disappeared. See code snippet below

spelling::spell_check_package()
#> DESCRIPTION does not contain 'Language' field. Defaulting to 'en-US'.
#> ...
#> recoded       cleanepi.Rmd:106
#> standardise   calculate_age.Rd:15
#> Standardise   cleanepi.Rmd:104

Since the epiverse collaboration has British institutions involved. It would make life easier to add this field to {packagetemplate} to reduce the number of false spelling mistakes that will be raised by using en-US by default.

@Bisaloo
Copy link
Member

Bisaloo commented Nov 22, 2023

I took some time to consider it because I find it a bit awkward to default to English if a project with many non-native English speakers and where we aim at being language-inclusive.

However, as you pointed out, the current situation already defaults to English so, although not ideal, defaulting to en-GB seems like a incremental improvement relative to en-US.

Could you submit a PR for this please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants