Simplify fit_seromodel() output and related refactorizations #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the removed preloaded dataset `serodata` for the identical `chagas2012`.
…ule. This change is meant to simplify `fit_seromodel()`. This commit also changes the name of the stanfit object in the output of `fit_seromodel()` from `fit` to `seromodel_fit`.
… .RDS and updates test_visualization accordingly
ntorresd
changed the title
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 82.18% 82.59% +0.40%
==========================================
Files 10 10
Lines 1684 1660 -24
==========================================
- Hits 1384 1371 -13
+ Misses 300 289 -11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Closed
ntorresd
requested review from
jpavlich
and removed request for
GeraldineGomez
Bisaloo
pushed a commit
that referenced
this pull request
Oct 10, 2023
Simplify fit_seromodel() output and related refactorizations
ntorresd
pushed a commit
that referenced
this pull request
Oct 10, 2023
Simplify fit_seromodel() output and related refactorizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #104 and implements a first simplification of
fit_seromodel()'s output (see #89).This PR should be merged after #107