Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer tools #134

Merged
merged 29 commits into from
Dec 16, 2023
Merged

Developer tools #134

merged 29 commits into from
Dec 16, 2023

Conversation

ntorresd
Copy link
Member

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR updates the package template files:

  • .github/workflows/pkgdown.yaml
  • tests/spelling.R
  • tests/testthat/helper-state.R
  • tests/testthat/setup-options.R
  • tools/check.env

In accordance to the discussion in November 2023 spring cleaning #101

Copy link
Member

@Bisaloo Bisaloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the other GitHub Actions workflows please?

@ntorresd
Copy link
Member Author

Could you also update the other GitHub Actions workflows please?

Done. Please let me know whether we should keep line 47 in test-coverage.yaml. @jpavlich , do you remember why we added this to the workflow?

@jpavlich
Copy link
Member

Could you also update the other GitHub Actions workflows please?

Done. Please let me know whether we should keep line 47 in test-coverage.yaml. @jpavlich , do you remember why we added this to the workflow?

That was to be able to use development versions of rstan. Since we are sticking only to CRAN versions, I guess we don't need it anymore

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (6f0bd07) 76.25% compared to head (a954927) 76.16%.

❗ Current head a954927 differs from pull request most recent head e7e32cd. Consider uploading reports for the commit e7e32cd to get more accurate results

Files Patch % Lines
R/visualisation.R 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   76.25%   76.16%   -0.09%     
==========================================
  Files          10       10              
  Lines        1617     1611       -6     
==========================================
- Hits         1233     1227       -6     
  Misses        384      384              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tools/check.env Outdated Show resolved Hide resolved
@Bisaloo
Copy link
Member

Bisaloo commented Dec 15, 2023

Clean diff is here: https://github.com/epiverse-trace/serofoi/compare/developer-tools2?expand=1. Can I force push it here? Alternatively, are you able to rebase yourself? You'll have to run git rebase --skip on empty commits.

@ntorresd
Copy link
Member Author

Clean diff is here: https://github.com/epiverse-trace/serofoi/compare/developer-tools2?expand=1. Can I force push it here?

Sure, please do. Sorry for the trouble.

@Bisaloo Bisaloo merged commit d857c1c into main Dec 16, 2023
7 checks passed
@Bisaloo Bisaloo deleted the developer-tools branch December 16, 2023 09:02
@ntorresd ntorresd restored the developer-tools branch December 19, 2023 16:12
@ntorresd ntorresd deleted the developer-tools branch December 19, 2023 16:13
@ntorresd
Copy link
Member Author

Closes #86 and #101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants