Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write function for running optimization #170

Closed
wants to merge 5 commits into from
Closed

Conversation

rccreswell
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • I have read the CONTRIBUTING guidelines
  • A new item has been added to NEWS.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Checks have been run locally and pass
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Preliminary work on allowing optimization in addition to MCMC sampling.

  • What is the current behavior? (You can also link to an open issue here)

Users can infer parameters by MCMC sampling. (See #63, #73 ).

  • What is the new behavior (if this is a feature change)?

Users can find best fit parameters via rstan::optimizing. They could pass best fit parameters as the initialization of MCMC chains.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Should not.

  • Other information

Draft PR, not ready for merging.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 15.78947% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 69.15%. Comparing base (e4072c9) to head (194c99f).

❗ Current head 194c99f differs from pull request most recent head 9ca3192. Consider uploading reports for the commit 9ca3192 to get more accurate results

Files Patch % Lines
R/modelling.R 15.78% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   70.37%   69.15%   -1.23%     
==========================================
  Files          10       10              
  Lines        1779     1812      +33     
==========================================
+ Hits         1252     1253       +1     
- Misses        527      559      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rccreswell
Copy link
Collaborator Author

Replaced by #189

@rccreswell rccreswell closed this May 13, 2024
@ntorresd ntorresd deleted the i63-i73-optimization branch August 7, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants