Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data simulation functions in vignettes instead of data(simdata_*) #184

Merged
merged 6 commits into from
May 9, 2024

Conversation

ntorresd
Copy link
Member

@ntorresd ntorresd commented May 9, 2024

  • Please check if the PR fulfills these requirements
  • I have read the CONTRIBUTING guidelines
  • A new item has been added to NEWS.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Checks have been run locally and pass
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

This PR:

- use same ylim in foi plots for better readability
- add environment cleanup at the end of each example
- use data simulation functionalities of the package to simulate the
datasets in `foi_models.Rmd` examples
- use same chunk structure in modelling to validate results
- overall cleanup of the vignette
@ntorresd ntorresd marked this pull request as ready for review May 9, 2024 16:39
@ntorresd ntorresd changed the title Remove simdata clean Use data simulation functions in vignettes instead of data(simdata_*) May 9, 2024
@ntorresd ntorresd merged commit d4f2d9c into dev May 9, 2024
7 checks passed
@ntorresd ntorresd deleted the remove-simdata-clean branch May 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant