Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev version #186

Closed
wants to merge 140 commits into from
Closed

Dev version #186

wants to merge 140 commits into from

Conversation

ntorresd
Copy link
Member

  • Please check if the PR fulfills these requirements
  • I have read the CONTRIBUTING guidelines
  • A new item has been added to NEWS.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Checks have been run locally and pass
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

ntorresd added 19 commits May 9, 2024 11:41
- use same ylim in foi plots for better readability
- add environment cleanup at the end of each example
- use data simulation functionalities of the package to simulate the
datasets in `foi_models.Rmd` examples
- use same chunk structure in modelling to validate results
- overall cleanup of the vignette
- Replace `prob_infected.stan` by two separate files for each
type of model
- Slight change to parameter order in `prob_infected_calculate`
…ation

- Change how `stan_data` is constructed depending on type of model
- Specify default behavior by type of model
- Use `age` for age-varying models and `years` in time-varying
models in
    - `get_foi_central_estimates`
    - `plot_foi`
    - `plot_rhats`
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 58.11%. Comparing base (20555d6) to head (45b08ee).
Report is 6 commits behind head on main.

❗ Current head 45b08ee differs from pull request most recent head dcc35a6. Consider uploading reports for the commit dcc35a6 to get more accurate results

Files Patch % Lines
R/visualisation.R 0.00% 41 Missing ⚠️
R/modelling.R 76.11% 16 Missing ⚠️
R/model_comparison.R 0.00% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #186       +/-   ##
===========================================
- Coverage   70.07%   58.11%   -11.96%     
===========================================
  Files          10       12        +2     
  Lines        1965     2488      +523     
===========================================
+ Hits         1377     1446       +69     
- Misses        588     1042      +454     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Set different init functions for log and no-log models
- Set defaults in the log and regular scale for sigma statistics
- Use Cauchy distribution for sigma prior in regular scale
- Use normal distribution for sigma prior in log scale
Current available options are:
- `'constant'`
- `'time'`
- `'age'`
Add examples for:
- `fit_seromodel`
- `get_foi_index`
- `plot_serosurvey`
@ntorresd ntorresd closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants