R-CMD-check / unixOS not passing

[davidsantiagoquevedo]

Please place an "x" in all the boxes that apply

• I have the most recent version of vaccineff and R
• I have found a bug
• I have a reproducible example
• I want to request a new feature

---

I encountered errors with snapshots when running R-CMD checks. I set a fixed seed to avoid this issue, and the tests work on Windows but not on Ubuntu/macOS.

See: https://github.com/epiverse-trace/vaccineff/actions/runs/9528509173/job/26323163065?pr=57

[jpavlich]

Hi @davidsantiagoquevedo I talked to @GeraldineGomez about this and I guess the best solution is to avoid using snapshots for this test. Instead, it would be better to test that the absolute difference between values is less than a threshold (e.g. 1e-2). I you agree I will implement a helper function to do this comparison.

[davidsantiagoquevedo]

Hi @jpavlich, thanks for the comment! Yeah, that sounds better. Let me know if you need any help.

[jpavlich]

@davidsantiagoquevedo I see that you have done lots of changes to tests in the branch refac-effectiveness-matching. Since I need to modify those tests I will wait until you have updated main with those changes. Let me know when you do it

Don't worry if said test still fails, since I will fix it as soon as you update main.

[Bisaloo]

Note that expect_snapshot_value() has a tolerance argument. Can we use this? It would prevent having to write custom code which then needs to be maintained.

[jpavlich]

@Bisaloo good to know that. I will do the change. Thanks