Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

59 r cmd check unixos not passing #61

Merged
merged 3 commits into from
Jul 22, 2024
Merged

59 r cmd check unixos not passing #61

merged 3 commits into from
Jul 22, 2024

Conversation

jpavlich
Copy link
Member

@jpavlich jpavlich commented Jul 17, 2024 •
edited
Loading

  • Added test for balance and summary snapshots using expect_snapshot_value with the tolerance parameter

@jpavlich jpavlich linked an issue Jul 17, 2024 that may be closed by this pull request
R-CMD-check / unixOS not passing #59
Closed
4 tasks
davidsantiagoquevedo
davidsantiagoquevedo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@davidsantiagoquevedo davidsantiagoquevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. The solution was very easy. Thanks @jpavlich

@davidsantiagoquevedo davidsantiagoquevedo merged commit 29f9910 into main Jul 22, 2024
6 checks passed
@davidsantiagoquevedo davidsantiagoquevedo deleted the 59-r-cmd-check-unixos-not-passing branch July 22, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsantiagoquevedo davidsantiagoquevedo davidsantiagoquevedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R-CMD-check / unixOS not passing
2 participants
@jpavlich @davidsantiagoquevedo