Feat matching #45
Merged
Feat matching #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: definition of age interval when (max_val-min_val)%%setp !=0. Added option to set interval '<min_val' when min_val<0 * refac: removed test forcing interval '>max_val', when (max_val-min_val)%%step!=0. Added test for min_val>0 * refac: step=10 on PH-accept test * feat: pulled description from previous PR * feat: warning for module of interval by step different to zero. Updated documentation of the function * simplified tests to control warning * roxygen: description of warning and lower value * fix: assert_number replaced by assert_integerish * fix: upper = max_val for assertion on min_val * style: documentation * fix: warning message for (max-min)%%step!=0 * roxygen: automatic update * fix: assert_integerish replaced by assert_int, better for integer numbers. Removed upper check for min_val to avoid redundancy with lower check for max_mal * fix: example in documentation * feat: test for non-integer values
…ing. Added fixed version of get_age_group
…efault and ratio = 1 in matchit
… feat-matching. Fixed get_age_group()
…excluding weights to pass gp()
…d throughout all the new functions
…ember of couple presents outcome before censoring date
davidsantiagoquevedo
merged commit 19d8bf6
into
refac-effectiveness-matching
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added features from static matching