Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc code simplifications #62

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Misc code simplifications #62

merged 5 commits into from
Jul 22, 2024

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Jul 18, 2024

  • 3207bd1 removes special handling of edge cases since checkmate works well with NULL as well. We can remove one mental step while reading the code
  • 69ce04f removes a for loop
  • dd766d7 uses the fact data.frame() is designed to already take a list of vectors to turn into columns

davidsantiagoquevedo
davidsantiagoquevedo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@davidsantiagoquevedo davidsantiagoquevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bisaloo. Very useful simplifications.

@davidsantiagoquevedo davidsantiagoquevedo merged commit 4eb34e1 into main Jul 22, 2024
6 checks passed
@davidsantiagoquevedo davidsantiagoquevedo deleted the hugo-misc-july2024 branch July 22, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsantiagoquevedo davidsantiagoquevedo davidsantiagoquevedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bisaloo @davidsantiagoquevedo