Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native Node.js ES Modules support #20

Closed
wants to merge 3 commits into from

Conversation

abdonrd
Copy link

@abdonrd abdonrd commented Jun 7, 2020

In this PR I add native Node.js ES Modules support.

Following the same recommendations as the Rollup plugins:

Fix #8.

@coveralls
Copy link

coveralls commented Jun 7, 2020

Coverage Status

Coverage decreased (-1.1%) to 98.876% when pulling cda1862 on abdonrd:native-esm into 49e230d on epoberezkin:master.

@abdonrd abdonrd changed the title Native esm Add native Node.js ES Modules support Jun 7, 2020
# Conflicts:
#	.travis.yml
@mzgajner
Copy link

mzgajner commented Nov 10, 2020

@epoberezkin is there any additional work that needs to be done to get this PR merged? I'd love to help.

It seems like a solid change and would unlock the use of the module with modern tools like vite and snowpack that rely on ES modules.

@thescientist13
Copy link

thescientist13 commented Mar 6, 2021

Myself (and a few others from the issue discussion) would definitely appreciate this landing. 🙏

@abdonrd
Copy link
Author

abdonrd commented Jul 12, 2021

Closing because no response.

@abdonrd abdonrd closed this Jul 12, 2021
@thescientist13
Copy link

sharing comments here from a similar thread for those following along #10 (comment) 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exporting as ES Module Syntax (ESM)
4 participants