Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in RUNPATH_FILE description #8397

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

hnformentin
Copy link
Contributor

Try to improve readability.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.87%. Comparing base (840f483) to head (5c3387a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8397      +/-   ##
==========================================
- Coverage   90.90%   90.87%   -0.03%     
==========================================
  Files         347      347              
  Lines       21068    21068              
==========================================
- Hits        19151    19146       -5     
- Misses       1917     1922       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andreas-el andreas-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Comment on lines +500 to +501
easily overflow the commandline buffer; the solution used is
to let ERT write a regular file. It looks like this::
Copy link
Contributor

@eivindjahren eivindjahren Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
easily overflow the commandline buffer; the solution used is
to let ERT write a regular file. It looks like this::
easily overflow the commandline buffer; the solution is
to let ERT write a file with the following contents::

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jus a small suggestion :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eivind. I would keep as it is just because I am too lazy to make a rebase on web version of Github :-)

@andreas-el andreas-el merged commit 99012ea into equinor:main Aug 6, 2024
36 of 37 checks passed
@hnformentin hnformentin deleted the patch-1 branch August 6, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants