Drop support for Python 3.6 and 3.7 #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
hnformentin
force-pushed
the
drop_36_37
branch
3 times, most recently
from
154a342
to
f9e1f1a
Compare
|
jenkins test this please |
|
Jenkins add to whitelist |
hnformentin
commented
Dec 5, 2022
external/Catch2/catch2/catch.hpp
Outdated
| @@ -10819,7 +10819,7 @@ namespace Catch { | |||
|
|
|||
| // 32kb for the alternate stack seems to be sufficient. However, this value | |||
| // is experimentally determined, so that's not guaranteed. | |||
| static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ; | |||
| static constexpr std::size_t sigStackSize = 32768; | |||
There was a problem hiding this comment.
Fix to test failing:
error: call to non-‘constexpr’ function ‘long int sysconf(int)’
hnformentin
force-pushed
the
drop_36_37
branch
from
c6ad8b9
to
f9e1f1a
Compare
hnformentin
force-pushed
the
drop_36_37
branch
from
f9e1f1a
to
2b612fc
Compare
|
The failing tests are not required and were failing on previous PRs as well. Will try to investigate... |
lars-petter-hauge
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #883
Approach
Remove code referring to python 3.6 and 3.7.