Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.6 and 3.7 #884

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Drop support for Python 3.6 and 3.7 #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/style.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

- name: Install dependencies
run: |
sudo pip install cmake-format black==22.1.0 'click<8;python_version<="3.6"' 'click==8.0.2;python_version >"3.6"'
sudo pip install cmake-format black==22.1.0

- name: Clang Format
run: ./script/clang-format --check
Expand Down
15 changes: 1 addition & 14 deletions .github/workflows/testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
fail-fast: false
matrix:
os: ['ubuntu-latest', 'macos-latest']
python: ['3.6', '3.7', '3.8', '3.9', '3.10', '3.11']
python: ['3.8', '3.9', '3.10', '3.11']

runs-on: ${{ matrix.os }}

Expand Down Expand Up @@ -79,19 +79,6 @@ jobs:
name: ${{ matrix.os }} Python ${{ matrix.python }} wheel
path: dist/*

- name: Build `libecl` migration package
run: |
pip install -U pip setuptools wheel setuptools_scm
python ci/github/setup.py bdist_wheel --dist-dir=dist-migration
if: matrix.os == 'ubuntu-latest' && matrix.python == '3.6'

- name: Upload `libecl` migration wheel as artifact
uses: actions/upload-artifact@v2
with:
name: Python libecl to ecl wheel
path: dist-migration/*
if: matrix.os == 'ubuntu-latest' && matrix.python == '3.6'

- name: Install ecl
run: pip install dist/*

Expand Down
2 changes: 1 addition & 1 deletion WINDOWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
cmake -G "Visual Studio 15 2017 Win64" -DCMAKE_INSTALL_PREFIX=%INSTALLPATH% -DBUILD_SHARED_LIBS="ON" -DENABLE_PYTHON="ON" -DCMAKE_BUILD_TYPE="Release" %SOURCEPATH%
cmake --build %BUILDPATH% --config Release --target install
~~~~
6. For **_libecl_** to be accessible in Python the `%INSTALLPATH%\lib\pythonX.Y\site-package` and Python subdirectories must be added to the `PATH` and `PYTHONPATH` variables. Where `pythonx.y` is the current Python version _e.g._ (`python2.7`, `python3.6` _etc._) .
6. For **_libecl_** to be accessible in Python the `%INSTALLPATH%\lib\pythonX.Y\site-package` and Python subdirectories must be added to the `PATH` and `PYTHONPATH` variables. Where `pythonx.y` is the current Python version _e.g._ (`python3.9`, `python3.10` _etc._) .

8. Open a Python interactive session and run `import ecl` to check that the install and paths are now set.
2 changes: 0 additions & 2 deletions ci/github/build_linux_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
set -euo pipefail

case "$1" in
3.6) pyver=cp36-cp36m ;;
3.7) pyver=cp37-cp37m ;;
3.8) pyver=cp38-cp38 ;;
3.9) pyver=cp39-cp39 ;;
3.10) pyver=cp310-cp310 ;;
Expand Down
2 changes: 0 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ def utility_wrappers():
"License :: OSI Approved :: GNU General Public License v3 (GPLv3)",
"Natural Language :: English",
"Programming Language :: Python",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
Expand Down