-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grav subs maps #703
Grav subs maps #703
Conversation
|
||
stations: | ||
grav: | ||
'2020_2018': /project/fmu/users/tral/subscript/subscript/tests/testdata_gravity/station_coordinates.csv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this configuration file has not been used for testing. But still it will be good to keep it as relative path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, this config was added to the test dataset, but will be used in a job not implemented yet. But will update to relative path now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. 👍
Not sure if there is a use case for running the script on CLI, but I think it will be great if more detail documentation can be provided, in addition to what you have made for ERT documentations (DESCRIPTION
and EXAMPLES
)
As example, you can check:
Thanks @alifbe. Will update with a more detailed documentation after adding the other gravity jobs. |
for phase in phases: | ||
logger.info( | ||
f"Calculating delta gravity map from {phase} " | ||
"for {diffdate[0]}_{diffdate[1]}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to add f
here otherwise it won't be expanded.
Added job for modelling of gravity and subsidence maps from flow simulation results.