Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grav subs maps #703

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Grav subs maps #703

merged 7 commits into from
Jun 5, 2024

Conversation

tralsos
Copy link
Collaborator

@tralsos tralsos commented Jun 4, 2024

Added job for modelling of gravity and subsidence maps from flow simulation results.


stations:
grav:
'2020_2018': /project/fmu/users/tral/subscript/subscript/tests/testdata_gravity/station_coordinates.csv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this configuration file has not been used for testing. But still it will be good to keep it as relative path.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, this config was added to the test dataset, but will be used in a job not implemented yet. But will update to relative path now.

Copy link
Collaborator

@alifbe alifbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 👍

Not sure if there is a use case for running the script on CLI, but I think it will be great if more detail documentation can be provided, in addition to what you have made for ERT documentations (DESCRIPTION and EXAMPLES)

As example, you can check:

@tralsos
Copy link
Collaborator Author

tralsos commented Jun 5, 2024

Thanks @alifbe. Will update with a more detailed documentation after adding the other gravity jobs.

for phase in phases:
logger.info(
f"Calculating delta gravity map from {phase} "
"for {diffdate[0]}_{diffdate[1]}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to add f here otherwise it won't be expanded.

@tralsos tralsos merged commit cb311d8 into equinor:main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants