Well Log Viewer: WellLogViewer callback subscriptions are set up in the wrong lifecycle hook

[Anders2303]

I messed up a little when I did #2196 : the WellLogViewer's callback manager subscriptions are being added in the constructor but they should be registered in the componentDidMount() hook. As is, the callbacks will be removed in the componentWillUnmount() hook, and then never be re-attached, right?

I'll set up a PR to fix this right away!

Aka, I need to move this:

constructor(props: WellLogViewerProps) {
       // ... 
       this.callbackManager.registerCallback(
           "onInfoGroupClick",
           this.onInfoGroupClick,
           true
       );

       if (props.onInfoFilled) {
           this.callbackManager.registerCallback(
               "onInfoFilled",
               props.onInfoFilled
           );
       }
   }

to this:

componentDidMount(): void {
        this.callbackManager.registerCallback(
            "onInfoGroupClick",
            this.onInfoGroupClick,
            true
        );

        if (this.props.onInfoFilled) {
            this.callbackManager.registerCallback(
                "onInfoFilled",
                this.props.onInfoFilled
            );
        }
       // ...
    }

[Anders2303]

On that note; in SyncLogViewer, I put the callbacks in fillViewCallbacks(), since I saw that's where the Callback-Managers were being created, but I now see that method gets called in beforeRender() so I believe I might be creating new listeners every render.

I see that this method is pushing new entries to this.callbackManagers and this.callbacks. Are these lists ever reset between renders? Or are we creating excess entries here ever single re-render? I'm a bit rusty on my React and it's lifecycle, so do correct me if Im wrong; but shouldn't fillViewsCallbacks be called in componentDidMount() instead?

[Anders2303]

I do see that the arrays in question are being truncated after the fillViewCallbakcs() loop, so the excess entries don't stick in memory. Still, is there a reason why these arrays are being filled every render?

   fillViewsCallbacks(nViews: number): void {
        for (let iView = this.callbacks.length; iView < nViews; iView++)
            this.fillViewCallbacks(iView);
        this.callbacks.length = nViews; // <---- here
        this.callbackManagers.length = nViews; //<---- and here

        for (let iView = nViews; iView < this.controllers.length; iView++) {
            console.assert(this.controllers[iView]);
            this.onDeleteController(iView, this.controllers[iView]);
        }
        this.controllers.length = nViews;
    }

[Anders2303]

Set up PR #2217 for the afforementioned WellLogViewer issue. I did not touch the SyncLogViewer, as I think that issue is unrelated enough that it can be moved to it's own issue.