Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [NGRM] - Strange artefacts in 2D maps #2134 #2135

Merged
merged 20 commits into from
Jul 8, 2024
Merged

fix: [NGRM] - Strange artefacts in 2D maps #2134 #2135

merged 20 commits into from
Jul 8, 2024

Conversation

nilscb
Copy link
Collaborator

@nilscb nilscb commented Jul 3, 2024

No description provided.

@nilscb nilscb added bug Something isn't working AspenTech Task owned by AspenTech labels Jul 3, 2024
@nilscb nilscb self-assigned this Jul 3, 2024
@nilscb nilscb linked an issue Jul 3, 2024 that may be closed by this pull request
[NGRM] - Strange artefacts in 2D maps #2134
Closed
@nilscb nilscb requested a review from w1nklr July 3, 2024 10:58
w1nklr
w1nklr requested changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@w1nklr w1nklr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check grid3d version ?

@nilscb
Copy link
Collaborator Author

nilscb commented Jul 4, 2024

Added same fix for grid3D layer

@nilscb nilscb requested a review from w1nklr July 4, 2024 07:57
@nilscb nilscb requested review from LeonidPolukhin and w1nklr July 4, 2024 08:51
LeonidPolukhin
LeonidPolukhin reviewed Jul 4, 2024
View reviewed changes
typescript/packages/subsurface-viewer/src/layers/grid3d/fragment.fs.glsl.ts Outdated

if (propertyValue < colorMapRangeMin - tolerance || propertyValue > colorMapRangeMax + tolerance) {

if (propertyValue < colorMapRangeMin || propertyValue > colorMapRangeMax) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that discrete property grids with clamping are colored correctly and there is no "color fighting"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the tolerances back in for this layer. Im not quite sure why they are needed in the continuous case.

@nilscb nilscb requested a review from LeonidPolukhin July 4, 2024 10:00
@nilscb nilscb requested review from w1nklr and LeonidPolukhin July 5, 2024 08:32
@nilscb nilscb merged commit 0446493 into equinor:master Jul 8, 2024
10 checks passed
hkfb pushed a commit that referenced this pull request Jul 18, 2024
@semantic-release-bot
chore(release): subsurface-viewer@0.27.10 [skip ci]
6747e3b 
## [0.27.10](https://github.com/equinor/webviz-subsurface-components/compare/subsurface-viewer@0.27.9...subsurface-viewer@0.27.10) (2024-07-18)

### Bug Fixes

* [NGRM] - Strange artefacts in 2D maps [#2134](#2134) ([#2135](#2135)) ([0446493](0446493))
* bump @equinor/videx-wellog from 0.9.4 to 0.10.0 in /typescript ([#2120](#2120)) ([614bc81](614bc81))
* bump @turf/simplify from 6.5.0 to 7.0.0 in /typescript ([#2144](#2144)) ([888d147](888d147)), closes [/github.com/Turfjs/turf/blob/master/CHANGELOG.md#700](https://github.com//github.com/Turfjs/turf/blob/master/CHANGELOG.md/issues/700) [#2158](#2158) [#2237](#2237) [#2177](#2177) [#2173](#2173) [#2393](#2393) [#2166](#2166) [#2183](#2183) [#2106](#2106) [#2106](#2106) [#2247](#2247) [#2247](#2247) [#2247](#2247) [#2613](https://github.com/equinor/webviz-subsurface-components/issues/2613) [#1896](#1896) [#2217](#2217) [#2231](#2231) [#1893](#1893) [#2033](#2033) [#2338](#2338) [#2415](https://github.com/equinor/webviz-subsurface-components/issues/2415) [#1450](#1450) [#2149](#2149) [#2323](#2323) [#2142](#2142) [#2316](#2316) [#2345](#2345) [#2178](#2178) [#2168](#2168) [#2174](#2174) [#2182](#2182) [#2171](#2171) [#2171](#2171) [#2167](#2167) [#2134](#2134) [#2169](#2169) [#2195](#2195) [#2216](#2216) [#2227](#2227) [#2172](#2172) [#2475](https://github.com/equinor/webviz-subsurface-components/issues/2475) [#2504](https://github.com/equinor/webviz-subsurface-components/issues/2504) [#2524](https://github.com/equinor/webviz-subsurface-components/issues/2524) [#2609](https://github.com/equinor/webviz-subsurface-components/issues/2609) [#2607](https://github.com/equinor/webviz-subsurface-components/issues/2607) [#2603](https://github.com/equinor/webviz-subsurface-components/issues/2603) [#2599](https://github.com/equinor/webviz-subsurface-components/issues/2599) [#2565](https://github.com/equinor/webviz-subsurface-components/issues/2565) [#2576](https://github.com/equinor/webviz-subsurface-components/issues/2576) [#2572](https://github.com/equinor/webviz-subsurface-components/issues/2572) [#2571](https://github.com/equinor/webviz-subsurface-components/issues/2571)
* bump ajv from 8.14.0 to 8.16.0 in /typescript ([#2138](#2138)) ([3f02100](3f02100)), closes [ajv-validator/ajv#2444](ajv-validator/ajv#2444) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [ajv-validator/ajv#2442](ajv-validator/ajv#2442) [ajv-validator/ajv#2415](ajv-validator/ajv#2415) [#2444](https://github.com/equinor/webviz-subsurface-components/issues/2444) [#2442](https://github.com/equinor/webviz-subsurface-components/issues/2442) [#2415](https://github.com/equinor/webviz-subsurface-components/issues/2415)
* bump mathjs from 12.4.2 to 13.0.0 in /typescript ([#2124](#2124)) ([caae3f2](caae3f2)), closes [#3223](https://github.com/equinor/webviz-subsurface-components/issues/3223) [#3139](https://github.com/equinor/webviz-subsurface-components/issues/3139) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [#3152](https://github.com/equinor/webviz-subsurface-components/issues/3152) [#2838](https://github.com/equinor/webviz-subsurface-components/issues/2838) [rawify/Fraction.js#68](rawify/Fraction.js#68) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#3207](https://github.com/equinor/webviz-subsurface-components/issues/3207) [#1240](#1240) [#3189](https://github.com/equinor/webviz-subsurface-components/issues/3189) [#3197](https://github.com/equinor/webviz-subsurface-components/issues/3197) [#3198](https://github.com/equinor/webviz-subsurface-components/issues/3198)
* Changed to low precission for uniform in grid3D layer. ([#2146](#2146)) ([736f5e7](736f5e7))
* Fixes failing smoke test for axes2D layer. ([#2150](#2150)) ([240ea8d](240ea8d))
* semantic release not publishing ([#2160](#2160)) ([235c558](235c558))
* semantic release not publishing ([#2164](#2164)) ([9878239](9878239))
@hkfb
Copy link
Collaborator

hkfb commented Jul 18, 2024

🎉 This issue has been resolved in version subsurface-viewer@0.27.10 🎉

The release is available on GitHub release

@hkfb hkfb added the released label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonidPolukhin LeonidPolukhin LeonidPolukhin approved these changes

@w1nklr w1nklr w1nklr approved these changes

Assignees

@nilscb nilscb

Labels
AspenTech Task owned by AspenTech bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[NGRM] - Strange artefacts in 2D maps
4 participants
@nilscb @hkfb @w1nklr @LeonidPolukhin