Merge pull request #34 from ergebnis/fix/singular

Fix: Account for a single slow test in report
ergebnis · Jan 25, 2021 · ef50128 · ef50128
2 parents 3b019a0 + 1713679
commit ef50128
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 1 deletion.
diff --git a/src/Reporter/DefaultReporter.php b/src/Reporter/DefaultReporter.php
@@ -76,6 +76,13 @@ private function header(SlowTest ...$slowTests): string
 
         $formattedMaximumDuration = $this->durationFormatter->format($this->maximumDuration);
 
+        if (1 === $count) {
+            return <<<TXT
+Detected {$count} test that took longer than {$formattedMaximumDuration}.
+
+TXT;
+        }
+
         return <<<TXT
 Detected {$count} tests that took longer than {$formattedMaximumDuration}.
 

diff --git a/test/Unit/Reporter/DefaultReporterTest.php b/test/Unit/Reporter/DefaultReporterTest.php
@@ -81,7 +81,49 @@ public function testReportReturnsEmptyStringWhenNoSlowTestsHaveBeenSpecified():
         self::assertSame('', $report);
     }
 
-    public function testReportReturnsReportWhenTheNumberOfSlowTestsIsSmallerThanTheMaximumCount(): void
+    public function testReportReturnsReportWhenTheNumberOfSlowTestsIsSmallerThanTheMaximumCountAndLessThanOne(): void
+    {
+        $slowTests = [
+            SlowTest::fromTestAndDuration(
+                new Event\Code\Test(
+                    Example\SleeperTest::class,
+                    'foo',
+                    'foo with data set #123',
+                ),
+                Event\Telemetry\Duration::fromSecondsAndNanoseconds(
+                    7,
+                    890_123_456
+                )
+            ),
+        ];
+
+        $durationFormatter = new ToMillisecondsDurationFormatter();
+
+        $maximumDuration = Event\Telemetry\Duration::fromSecondsAndNanoseconds(
+            0,
+            100_000_000
+        );
+
+        $maximumNumber = \count($slowTests);
+
+        $reporter = new DefaultReporter(
+            $durationFormatter,
+            $maximumDuration,
+            $maximumNumber
+        );
+
+        $report = $reporter->report(...$slowTests);
+
+        $expected = <<<'TXT'
+Detected 1 test that took longer than 100 ms.
+
+7,890 ms: Ergebnis\PHPUnit\SlowTestDetector\Test\Example\SleeperTest::foo with data set #123
+TXT;
+
+        self::assertSame($expected, $report);
+    }
+
+    public function testReportReturnsReportWhenTheNumberOfSlowTestsIsSmallerThanTheMaximumCountAndGreaterThanOne(): void
     {
         $faker = self::faker();