Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract Duration #351

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Enhancement: Extract Duration #351

merged 1 commit into from
Nov 1, 2023

Conversation

localheinz
Copy link
Member

This pull request

  • extracts Duration as a value object

Related to #291.

@localheinz localheinz self-assigned this Nov 1, 2023
@localheinz localheinz changed the title Enhancement: Extract Duration Enhancement: Extract Duration Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #351 (fd60b37) into main (61a4f7d) will increase coverage by 0.74%.
The diff coverage is 98.38%.

❗ Current head fd60b37 differs from pull request most recent head b18a2d5. Consider uploading reports for the commit b18a2d5 to get more accurate results

@@             Coverage Diff              @@
##               main     #351      +/-   ##
============================================
+ Coverage     94.64%   95.38%   +0.74%     
- Complexity       61       77      +16     
============================================
  Files            15       18       +3     
  Lines           299      347      +48     
============================================
+ Hits            283      331      +48     
  Misses           16       16              
Files Coverage Δ
src/Comparator/DurationComparator.php 100.00% <ø> (ø)
src/Duration.php 100.00% <100.00%> (ø)
src/Exception/InvalidNanoseconds.php 100.00% <100.00%> (ø)
src/Exception/InvalidSeconds.php 100.00% <100.00%> (ø)
src/Formatter/DefaultDurationFormatter.php 100.00% <100.00%> (ø)
src/MaximumDuration.php 100.00% <100.00%> (ø)
src/Reporter/DefaultReporter.php 95.83% <100.00%> (ø)
src/SlowTest.php 100.00% <100.00%> (ø)
src/Subscriber/TestPassedSubscriber.php 97.22% <100.00%> (ø)
src/TimeKeeper.php 76.47% <83.33%> (+7.23%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@localheinz localheinz merged commit 6d71578 into main Nov 1, 2023
16 checks passed
@localheinz localheinz deleted the feature/duration branch November 1, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants