Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse composed messages #1387

Closed
slingamn opened this issue Nov 16, 2020 · 0 comments
Closed

reuse composed messages #1387

slingamn opened this issue Nov 16, 2020 · 0 comments
Milestone

Comments

@slingamn
Copy link
Member

The devel+sharedbuffers branch is a prototype of this; IIRC the speedup on the chanflood benchmark was about 30%. We'll probably get a bit less.

Here's the proposal: for each PRIVMSG/NOTICE/TAGMSG, cache 2 versions of the built message. One is for clients with message-tags negotiated: these clients are eligible to receive account-tag (where applicable), server-time, etc., so we'll send them a cached "full" message with all tags. The other is for clients that have no tag capabilities negotiated (neither message-tags, nor server-time, nor account-tag, nor anything else that would indicate the ability to receive tags): they'll get a cached message with no tags. Other clients will go through the current flow where we build an individual copy of the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant