fix #1387 #1400
Merged
fix #1387 #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of building a new serialized message for each recipient, try to cache them.
|
It's probably perfectly safe to cut the batch IDs in half (going from 26 bytes to 13 bytes on the wire, and from 128 to 64 bits of entropy). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I measured a speedup of around 20% on the chanflood benchmark from this.
One area where this actually makes things worse: we're using longer batch IDs now when relaying multilines, because they're shared globally (due to caching) so we need to make them longer for uniqueness. This could conceivably reduce performance in some workloads.
The new bitset routines are not used.