Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+s channels don't appear in /list even though on the channel #1911

Closed
Jigsy1 opened this issue Jan 27, 2022 · 2 comments
Closed

+s channels don't appear in /list even though on the channel #1911

Jigsy1 opened this issue Jan 27, 2022 · 2 comments

Comments

@Jigsy1
Copy link

Jigsy1 commented Jan 27, 2022

One of the networks I'm on uses this IRCd.

I couldn't help notice that even though I'm actually on a channel that's +s, the channel itself doesn't appear in the /list.

@pcho
Copy link

pcho commented Feb 4, 2022

Is it really a bug? Per RFC it should not display +s channels while using /list.

   The channel flag 'p' is used to mark a channel "private" and the
   channel flag 's' to mark a channel "secret".  Both properties are
   similar and conceal the existence of the channel from other users.

   This means that there is no way of getting this channel's name from
   the server without being a member.  In other words, these channels
   MUST be omitted from replies to queries like the WHOIS command.

   When a channel is "secret", in addition to the restriction above, the
   server will act as if the channel does not exist for queries like the
   TOPIC, LIST, NAMES commands.  Note that there is one exception to
   this rule: servers will correctly reply to the MODE command.
   Finally, secret channels are not accounted for in the reply to the
   LUSERS command (See "Internet Relay Chat: Client Protocol" [IRC-
   CLIENT]) when the <mask> parameter is specified.

   The channel flags 'p' and 's' MUST NOT both be set at the same time.
   If a MODE message originating from a server sets the flag 'p' and the
   flag 's' is already set for the channel, the change is silently
   ignored.  This should only happen during a split healing phase
   (mentioned in the "IRC Server Protocol" document [[IRC-SERVER].

https://datatracker.ietf.org/doc/html/rfc2811#section-4.2.6

I think it should not be visible to IRC Operators also. :)

@slingamn
Copy link
Member

slingamn commented Feb 4, 2022

Discussed; this is still a bug as per Modern, which is authoritative here:

https://modern.ircdocs.horse/#secret-channel-mode

We should document that operators need the sajoin capability to see +s channels in LIST.

FiskFan1999 added a commit to FiskFan1999/ergo that referenced this issue Feb 28, 2022
FiskFan1999 added a commit to FiskFan1999/ergo that referenced this issue Feb 28, 2022
slingamn pushed a commit that referenced this issue Jun 9, 2022
#1923)

* Fix #1911 +s channels don't appear in /list even though on the channel

* use channel.HasClient instead of custom iterative checker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants