Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added test: LIST shows mode +s channels which the user has joined. #20

Closed
wants to merge 2 commits into from
Closed

added test: LIST shows mode +s channels which the user has joined. #20

wants to merge 2 commits into from

Conversation

FiskFan1999
Copy link

@slingamn
Copy link
Member

slingamn commented Mar 1, 2022

This looks great, thanks. Can you:

  1. In the cases where a RPL_LIST response is expected, assert that there is only one such line, and then use assertMessageMatch on the RPL_LIST responses to verify that it corresponds to the correct channel?
  2. PR this to progval/irctest (the upstream repository)?

@FiskFan1999
Added assertions for exact content of lines with command RPL_LIST and…
f56b537 
… checks for exact number of RPL_LIST replies
@FiskFan1999
Copy link
Author

Hey @slingamn thanks for your comments, I added the suggestions, let me know if you have any more suggestions :) Going to PR to progval now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FiskFan1999 @slingamn