two bugs with request param
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it would return only two items: the first non-`none` algorithm, and `none`. This doesn't appear to be what we want: instead, we want the full list in their regular order, but with `none` at the end. Related to erlef#297, as the root cause of the crash I was seeing was the the first algorithm in the authorizer's list wasn't supported by JOSE, so we went immediately to `none`.
paulswartz
added a commit
to paulswartz/oidcc
that referenced
this pull request
Jun 7, 2024
Originally done in erlef#299, this doesn't seem correct in practice. In particular, a team ran into this issue with Keycloak, where passing the `kc_action` parameter only works when it's included in the request object. I also tried this with the conformance suite, and all the tests continue to pass with this change.
paulswartz
added a commit
to paulswartz/oidcc
that referenced
this pull request
Jun 7, 2024
Originally done in erlef#299, this doesn't seem correct in practice. In particular, a team ran into this issue with Keycloak, where passing the `kc_action` parameter only works when it's included in the request object. I also tried this with the conformance suite, and all the tests continue to pass with this change.
maennchen
pushed a commit
to paulswartz/oidcc
that referenced
this pull request
Jun 12, 2024
Originally done in erlef#299, this doesn't seem correct in practice. In particular, a team ran into this issue with Keycloak, where passing the `kc_action` parameter only works when it's included in the request object. I also tried this with the conformance suite, and all the tests continue to pass with this change.
maennchen
pushed a commit
to paulswartz/oidcc
that referenced
this pull request
Jun 12, 2024
Originally done in erlef#299, this doesn't seem correct in practice. In particular, a team ran into this issue with Keycloak, where passing the `kc_action` parameter only works when it's included in the request object. I also tried this with the conformance suite, and all the tests continue to pass with this change.
paulswartz
added a commit
to paulswartz/oidcc
that referenced
this pull request
Jun 17, 2024
Originally done in erlef#299, this doesn't seem correct in practice. In particular, a team ran into this issue with Keycloak, where passing the `kc_action` parameter only works when it's included in the request object. I also tried this with the conformance suite, and all the tests continue to pass with this change.
maennchen
pushed a commit
that referenced
this pull request
Jun 18, 2024
Originally done in #299, this doesn't seem correct in practice. In particular, a team ran into this issue with Keycloak, where passing the `kc_action` parameter only works when it's included in the request object. I also tried this with the conformance suite, and all the tests continue to pass with this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More notes in the individual commits, but the tl;dr;
url_extensionparameters in the URL even when using arequestparam