-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: url_extension params also go in the request object #354
Conversation
d27004e
to
ae0255e
Compare
@paulswartz I'm wondering if this is the correct course of actions. The parameter is called I also haven't seen anywhere the explicitly forbids adding URL parameters when using request objects. Maybe we have to introduce a new parameter? That do you think? |
ae0255e
to
580dd67
Compare
Pull Request Test Coverage Report for Build 189Details
💛 - Coveralls |
Thanks for fixing the tests! I dug back into the spec:
I'm thinking that the solution is to send the |
@paulswartz Agreed. Let‘s do that 👍 |
Originally done in erlef#299, this doesn't seem correct in practice. In particular, a team ran into this issue with Keycloak, where passing the `kc_action` parameter only works when it's included in the request object. I also tried this with the conformance suite, and all the tests continue to pass with this change.
580dd67
to
ed07fbc
Compare
Pull Request Test Coverage Report for Build 190Details
💛 - Coveralls |
@maennchen this is ready for review now. I've tested it with the team that was experiencing the original issue and this addresses their issue. |
Originally done in #299, this doesn't seem correct in practice. In particular, a team ran into this issue with Keycloak, where passing the
kc_action
parameter only works when it's included in the request object.I also tried this with the conformance suite, and all the tests continue to pass with this change.
The test failures in Zitadel seem unrelated, as I also see them onmain
; @maennchen any ideas there?