Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for io.js #2

Merged
merged 3 commits into from
Jul 28, 2015
Merged

Support for io.js #2

merged 3 commits into from
Jul 28, 2015

Conversation

ide
Copy link
Contributor

@ide ide commented Jun 24, 2015

  • Added test case for a stack trace from io.js 2.3.0 (worked fine, didn't require changes)
  • Added Travis configuration

@ide
Copy link
Contributor Author

ide commented Jun 24, 2015

@Calamari are you interested in maintaining this repo? Wondering since there wasn't any feedback left on #1.

ide added 2 commits June 30, 2015 03:59
The pattern for Gecko-style traces can match both URLs that start with a protocol and also local file paths when running scripts in JavaScriptCore. Allow files to start with any non-space character which covers periods, hyphens, and underscores for example.
@ide ide changed the title Support for JSC and io.js Support for io.js Jun 30, 2015
@ide
Copy link
Contributor Author

ide commented Jul 3, 2015

@Calamari sorry to bother you -- could you take a look at this PR?

@ide
Copy link
Contributor Author

ide commented Jul 16, 2015

@Calamari - ping

@Calamari
Copy link
Contributor

Pong.. I am currently without notebook on vacation since bit over 2 weeks
and for one more week. But I will take a look directly afterwards.
On 16 Jul 2015 02:57, "James Ide" notifications@github.com wrote:

@Calamari https://github.com/Calamari - ping


Reply to this email directly or view it on GitHub
#2 (comment)
.

@ide
Copy link
Contributor Author

ide commented Jul 18, 2015

Cool. Thanks for the update =)

Run on Node 0.10 and 0.12 and io.js 1.x and 2.x.
Calamari added a commit that referenced this pull request Jul 28, 2015
Support and test cases for io.js
@Calamari Calamari merged commit bcff42f into errwischt:master Jul 28, 2015
@ide
Copy link
Contributor Author

ide commented Jul 28, 2015

Thanks! Could you publish a new release to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants