Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to io.js and Node.next #1737

Closed
9 of 11 tasks
ide opened this issue Jun 24, 2015 · 2 comments
Closed
9 of 11 tasks

Upgrading to io.js and Node.next #1737

ide opened this issue Jun 24, 2015 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Jun 24, 2015

io.js is the modern version of Node for practical intents and purposes and is way ahead since it uses a maintained version of V8 that is faster and has ES6 features, and the Node talent is almost totally focused on io.js.

The two projects are planning to converge by using the Node.js name and the io.js codebase, roughly speaking, so a future version of Node (ex: Node 3.0) will be running io.js under the hood. So insofar as skating towards where the puck will be is a good thing it makes sense to target io.js. This is a list of things I think need to happen for the upgrade:

@ide
Copy link
Contributor Author

ide commented Jun 30, 2015

Some rough perf numbers:

function run() {
  var reactNativeRoot = path.resolve(__dirname, '../react-native');
  var startTime = Date.now();
  return ReactPackager.buildPackageFromUrl({
    assetRoots: [reactNativeRoot],
    blacklistRE: blacklist(false),
    cacheVersion: '' + mathjs.randomInt(10, 1000000000),
    transformModulePath: path.join(reactNativeRoot, 'packager/transformer.js'),
    projectRoots: [reactNativeRoot]
  }, '/Examples/UIExplorer/UIExplorerApp.ios.includeRequire.runModule.bundle?dev=false&minify=true')
  .then(function() {
    console.log(Date.now() - startTime);
  });
}
  • io.js 2.3.1: ~5900ms (median-ish after running it a couple times)
  • Node 0.12.4: ~6300ms
  • Node 0.10.38: ~6400ms

a2 pushed a commit to a2/react-native that referenced this issue Jul 1, 2015
Summary:
This omits the devDependencies (e.g. test infra), which are intended only for people working on RN.

Part of facebook#1737.
Closes facebook#1803
Github Author: James Ide <ide@jameside.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
@ide
Copy link
Contributor Author

ide commented Aug 15, 2015

We're in good shape now. The websockets module just added support for io.js 3.x, which means it should work out of the box with Node 4 coming next month.

@ide ide closed this as completed Aug 15, 2015
@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants