Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Post release announcements across services #67

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Nov 26, 2024

Prerequisites checklist

What is the purpose of this pull request?

Update how we post release announcements. This will now post to Twitter, Mastodon, and Bluesky.

What changes did you make? (Give an overview)

  • Switched to use @humanwhocodes/crosspost to post across multiple services in one step
  • Added organization secrets and variables for the BlueSky info

Related Issues

Is there anything you'd like reviewers to focus on?

I've tested this on my own project and it worked, but want to just try this out on one of our repos to verify that everything is configured correctly before rolling out across the org.

@nzakas
Copy link
Member Author

nzakas commented Nov 26, 2024

I don't understand why there's a Prettier error. When I check locally everything is fine. 🤔

@fasttime
Copy link
Member

Prettier v3.4 was published today and it expects Markdown list items to contain only one space after the leading -: https://prettier.io/blog/2024/11/26/3.4.0#markdown.

@fasttime
Copy link
Member

I don't understand why there's a Prettier error. When I check locally everything is fine. 🤔

@nzakas I can see the errors after deleting and reinstalling node_modules. Maybe we should update the prettier dependency to "^3.4.1" in package.json to make sure everybody has the latest version. If we don't want to have to change the formatting after a minor Prettier release, we could also pin the minor version with "~3.4.1".

@nzakas
Copy link
Member Author

nzakas commented Nov 26, 2024

Ah thanks. That's annoying. I've updated the PR.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! It's fine to test the new announcements tool on this repo first.

@fasttime fasttime merged commit 9218110 into main Nov 27, 2024
16 checks passed
@fasttime fasttime deleted the social-posts branch November 27, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants