fix: Update RuleVisitor type #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
fasttime
reviewed
Nov 26, 2024
Co-authored-by: Francesco Trotta <github@fasttime.org>
fasttime
reviewed
Nov 26, 2024
Co-authored-by: Francesco Trotta <github@fasttime.org>
|
Oh, now Prettier 3.4 is complaining because of the formatting of Markdown files. It's the same problem as with eslint/json#67.
|
|
I guess their semver policy isn't a strict as ours. 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Make
RuleVisitortype work practically with subinterfaces.What changes did you make? (Give an overview)
RuleVisitorinterface into a mapped type.Related Issues
fixes #134
Is there anything you'd like reviewers to focus on?
The typescript-eslint rule recommended using a record instead of an object type. Does that make sense?