Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-195: PHP 8 docker container updates #196

Merged
merged 3 commits into from
Aug 11, 2022
Merged

ISSUE-195: PHP 8 docker container updates #196

merged 3 commits into from
Aug 11, 2022

Conversation

aksm
Copy link
Contributor

@aksm aksm commented Aug 11, 2022

Resolves #195

@aksm aksm added the Docker Containers All about those tiny little critters label Aug 11, 2022
@aksm aksm added this to the 1.0.0 milestone Aug 11, 2022
@aksm aksm requested a review from DiegoPino August 11, 2022 00:42
@aksm aksm self-assigned this Aug 11, 2022
Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you! It works right? 😃

@DiegoPino DiegoPino merged commit 2c68e02 into esmero:1.0.0 Aug 11, 2022
@aksm
Copy link
Contributor Author

aksm commented Aug 11, 2022

@DiegoPino Your trust is misplaced! I think I'm still missing something. Not working on Linux at the moment, even after matching up all the configuration settings one-by-one with a working deployment. Will circle back in the morning and make another PR.

Copy link
Member

@DiegoPino DiegoPino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the .ini ... I think the defaults are not as default as apparent

;xdebug.start_with_request=yes
;xdebug.connect_timeout_ms=500
;xdebug.mode=develop,debug
;xdebug.start_with_request=trigger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be the issue? xdebug.start_with_request twice, last one with "trigger" ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docker Containers All about those tiny little critters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants