Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-195: PHP 8 docker container updates #196

Merged
merged 3 commits into from
Aug 11, 2022
Merged

ISSUE-195: PHP 8 docker container updates #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a29c6fb
Update docker image to PHP 8 container with intl extension.
Aug 10, 2022
8b626e2
Clean up and comment xdebug.ini
Aug 11, 2022
e4ef350
Change name of mounted xdebug.ini file so it loads after esmero-php-d…
Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose-arm64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ services:
php:
container_name: esmero-php
restart: always
image: "esmero/php-8.0-fpm:1.0.0-multiarch"
image: "esmero/php-8.0-fpm:1.1.0-multiarch"
tty: true
networks:
- host-net
Expand Down
2 changes: 1 addition & 1 deletion docker-compose-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ services:
php:
container_name: esmero-php
restart: always
image: "esmero/php-8.0-fpm:1.0.0-multiarch"
image: "esmero/php-8.0-fpm:1.1.0-multiarch"
tty: true
networks:
- host-net
Expand Down
2 changes: 1 addition & 1 deletion docker-compose-osx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ services:
php:
container_name: esmero-php
restart: always
image: "esmero/php-8.0-fpm:1.0.0-multiarch"
image: "esmero/php-8.0-fpm:1.1.0-multiarch"
tty: true
networks:
- host-net
Expand Down
4 changes: 2 additions & 2 deletions docker-compose.dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ services:
php-debug:
container_name: esmero-php-debug
restart: always
image: esmero/php-8.0-fpm:1.0.0-dev-multiarch
image: esmero/php-8.0-fpm:1.1.0-dev-multiarch
environment:
- XDEBUG_SESSION_START="archipelago"
tty: true
Expand All @@ -37,4 +37,4 @@ services:
- esmero-net
volumes:
- ${PWD}:/var/www/html:cached
- ${PWD}/xdebug/xdebug.ini:/usr/local/etc/php/conf.d/docker-php-ext-xdebug.ini
- ${PWD}/xdebug/xdebug.ini:/usr/local/etc/php/conf.d/20-xdebug.ini
18 changes: 12 additions & 6 deletions xdebug/xdebug.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
zend_extension=xdebug
; The below xdebug settings are part of the esmero-php-debug container. You may override any of the settings or add additional ones (see https://xdebug.org/docs/all_settings) as needed.

;xdebug.remote_handler=dbgp
;xdebug.client_port=9999
;xdebug.start_with_request=yes
;xdebug.connect_timeout_ms=500
;xdebug.mode=develop,debug
;xdebug.start_with_request=trigger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be the issue? xdebug.start_with_request twice, last one with "trigger" ?

;xdebug.idekey=archipelago
;xdebug.client_host=host.docker.internal
;xdebug.log=/tmp/xdebug.log

[xdebug]
xdebug.mode=develop,debug
; If your host system is Linux, host.docker.internal may not be available.
xdebug.client_host=host.docker.internal
; On linux comment xdebug.client_host=host.docker.internal and uncomment the following next line
; On Linux uncomment the following next line
;xdebug.discover_client_host=1
xdebug.start_with_request=yes