ISSUE-199: Update Object Description Twig template to use Bootstrap accordion

[aksm]

Resolves #199

Thanks @alliomeria and @DiegoPino ! Have to run right now, but will test before the day is through.

[aksm]

This should be ok now, but I discovered another problem with this template. Will open another issue.

[alliomeria]

Hi @aksm --regarding that other issue you opened, dropped off a comment about the latest commit from yesterday having addressed that problem. I just made second update/commit, reflecting the bootstrap accordion section changes as well via ca99ef9 --but think this differs a bit from yours related to the different accordion attributes.

[DiegoPino]

Hi. Promise i will review this template thoroughly tomorrow and fix i find any issues. Thx to both for your work on this. Good night 🌙

On Fri, Aug 12, 2022 at 11:03 PM Allison Lund ***@***.***> wrote: Hi @aksm <https://github.com/aksm> --regarding that other issue <#201> you opened, dropped off a comment about the latest commit from yesterday having addressed that problem. I just made second update/commit, reflecting the bootstrap accordion section changes as well via ca99ef9 <ca99ef9> --but think this differs a bit from yours related to the different accordion attributes. — Reply to this email directly, view it on GitHub <#200 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU7ZZZG37BZWX262ZL6SSDVY4GA7ANCNFSM56M2PVYQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)

[alliomeria]

Thanks @DiegoPino & @aksm! Goodnight 😴

[aksm]

Thanks @alliomeria and @DiegoPino, I've added the is empty check to the template json for ingest so this should be good now? Hopefully I didn't miss anything. Just ingested the template now, and all seems good.

[alliomeria]

Thanks @aksm! Sorry for the confusion about the reverted correction popping back in there for a moment. I made that change on Thursday, and didn't notice that it had been reverted in my local on Friday when we updated/synced again. Glad all is set aright with this template again!

Have a good rest of your weekend @aksm & @DiegoPino!

[DiegoPino]

All good. You too Allison

On Sat, Aug 13, 2022 at 3:03 PM Allison Lund ***@***.***> wrote: Thanks @aksm <https://github.com/aksm>! Sorry for the confusion about the reverted correction popping back in there for a moment. I made that change on Thursday, and didn't notice that it had been reverted in my local on Friday when we updated/synced again. Glad all is set aright with this template again! Have a good rest of your weekend @aksm <https://github.com/aksm> & @DiegoPino <https://github.com/DiegoPino>! — Reply to this email directly, view it on GitHub <#200 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU7ZZ4TEJ2JCUFBSQVHHKDVY7WR3ANCNFSM56M2PVYQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)

[DiegoPino]

Great! Will test in the afternoon. Trying today to be a human and cleaning (or a hooman):)

On Sat, Aug 13, 2022 at 2:12 PM Albert Min ***@***.***> wrote: Thanks @alliomeria <https://github.com/alliomeria> and @DiegoPino <https://github.com/DiegoPino>, I've added the is empty check to the template json for ingest so this should be good now? Hopefully I didn't miss anything. Just ingested the template now, and all seems good. — Reply to this email directly, view it on GitHub <#200 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABU7ZZZBOCJHHQOBVFHUWDLVY7QSPANCNFSM56M2PVYQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)