Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded USB generics #1469

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

MabezDev
Copy link
Member

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Closes #1465

Testing

Running the usb_serial example

@MabezDev
Copy link
Member Author

I will draft this till after the release is out, I imagine we will want an answer to #1468 before merging this to avoid unnecessary churn.

@MabezDev MabezDev marked this pull request as draft April 17, 2024 23:46
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 oh yes - keeping the pins in the struct is unnecessary

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@MabezDev MabezDev mentioned this pull request Apr 18, 2024
3 tasks
@jessebraham jessebraham marked this pull request as ready for review April 22, 2024 16:57
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a CHANGELOG.md entry for this please?

@MabezDev MabezDev force-pushed the remove-usb-generics branch from 6363ad9 to 297b1cc Compare April 22, 2024 17:20
@MabezDev MabezDev enabled auto-merge April 22, 2024 17:21
@MabezDev MabezDev added this pull request to the merge queue Apr 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 22, 2024
@MabezDev MabezDev force-pushed the remove-usb-generics branch from 297b1cc to d6badf2 Compare April 22, 2024 18:43
@MabezDev
Copy link
Member Author

#1473 included this change, force merging for the changelog entry

@MabezDev MabezDev merged commit dd8083d into esp-rs:main Apr 22, 2024
1 check passed
@MabezDev MabezDev deleted the remove-usb-generics branch April 22, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unneeded type info on USB OTG struct
4 participants