Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel case structs #1473

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Camel case structs #1473

merged 3 commits into from
Apr 22, 2024

Conversation

MabezDev
Copy link
Member

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Builds on top of #1469

Following on from #1468, this renames all offending drivers. I also took the liberty of nuking some unused GPIO code.

@MabezDev MabezDev force-pushed the camel-case-structs branch 2 times, most recently from b66e36e to 53dc6be Compare April 18, 2024 19:56
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice improvement

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a CHANGELOG.md entry please?

@MabezDev MabezDev force-pushed the camel-case-structs branch from 53dc6be to 6ec95f4 Compare April 22, 2024 17:19
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham enabled auto-merge April 22, 2024 17:21
@jessebraham jessebraham added this pull request to the merge queue Apr 22, 2024
Merged via the queue into esp-rs:main with commit 56a7553 Apr 22, 2024
21 checks passed
@MabezDev MabezDev mentioned this pull request Apr 22, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants