Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embassy enable thread and interrupt by default, enable embassy when building docs #1485

Merged

Conversation

MabezDev
Copy link
Member

@MabezDev MabezDev commented Apr 20, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • My changes were added to the CHANGELOG.md in the proper section.

Extra:

Pull Request Details 📖

Description

Closes #1484, it also enables the embassy feature to be build in the docs run.

TODO

  • Fix up missing docs from the executor module
  • Re write the top level docs
  • More testing? Can we add a HIL test to test our interrupt executor (and in the future multi-core thread mode one)?

@MabezDev MabezDev mentioned this pull request Apr 21, 2024
3 tasks
@bjoernQ
Copy link
Contributor

bjoernQ commented Apr 22, 2024

I like the idea - if we can somehow make something similar for the time-drivers using embassy on ESP32 will become a much, nicer experience!

@MabezDev MabezDev changed the title Embassy enable thread and interrupt by default Embassy enable thread and interrupt by default, enable embassy when building docs Apr 24, 2024
@MabezDev MabezDev force-pushed the embassy-enable-thread-and-interrupt branch 3 times, most recently from d3cf40b to 24510e3 Compare May 1, 2024 13:19
@MabezDev MabezDev marked this pull request as ready for review May 1, 2024 14:54
@MabezDev MabezDev force-pushed the embassy-enable-thread-and-interrupt branch from 8c7504f to ee554e5 Compare May 1, 2024 15:03
@MabezDev MabezDev mentioned this pull request May 1, 2024
3 tasks
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a change in esp-wifi but for the next HAL release we already need to change a couple of things there ... so just one thing more

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! There is one discussion thread still open, could we merge this as is?

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@jessebraham jessebraham enabled auto-merge May 2, 2024 14:13
@MabezDev MabezDev force-pushed the embassy-enable-thread-and-interrupt branch 3 times, most recently from 13625ec to 6cdec09 Compare May 2, 2024 15:45
@MabezDev MabezDev force-pushed the embassy-enable-thread-and-interrupt branch from 6cdec09 to 8fd96ca Compare May 2, 2024 15:46
@jessebraham jessebraham added this pull request to the merge queue May 2, 2024
Merged via the queue into esp-rs:main with commit f32565b May 2, 2024
22 checks passed
@MabezDev MabezDev deleted the embassy-enable-thread-and-interrupt branch May 2, 2024 20:30
@kaspar030
Copy link
Contributor

Hey everyone!

We're using a custom executor inside a thread. Unfortunately making the use of esp-hal-embassy's executors always included clashes with that even if we don't initialize those executors because __pender() is defined twice.

Could we make inclusion of the executors optional again? I'd suggest a single feature executors that's default. Alternatively, a feature no-executors that's opt-in and would disable all esp-hal-embassy executor code.

@kaspar030
Copy link
Contributor

I'd suggest a single feature executors that's default.

I implemented this in #1683.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable embassy-executor-* by default when embassy is enabled
6 participants