-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embassy enable thread and interrupt by default, enable embassy when building docs #1485
Embassy enable thread and interrupt by default, enable embassy when building docs #1485
Conversation
I like the idea - if we can somehow make something similar for the time-drivers using |
d3cf40b
to
24510e3
Compare
8c7504f
to
ee554e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need a change in esp-wifi but for the next HAL release we already need to change a couple of things there ... so just one thing more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! There is one discussion thread still open, could we merge this as is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for this!
13625ec
to
6cdec09
Compare
…e embassy feature enabled
6cdec09
to
8fd96ca
Compare
Hey everyone! We're using a custom executor inside a thread. Unfortunately making the use of Could we make inclusion of the executors optional again? I'd suggest a single feature |
I implemented this in #1683. |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
Closes #1484, it also enables the embassy feature to be build in the docs run.
TODO