-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
embassy-usb support #1517
embassy-usb support #1517
Conversation
This is a bit hacky but it works on at least the S2. There are some code quality issues (e.g. missing documentation), and I couldn't figure out how to make the new dependencies not be included for other targets. The example is a blend of the esp-hal and the embassy-stm32 usb_serial examples. |
Awesome! Do we know if/when I think we should remove the logger-init from the examples - I personally like it but not everyone does (and I think I forgot to remove one of them myself before 🤔 ) |
I don't think it needs to cook for long, but dirbaio probably will want to make sure we don't end up breaking
Apologies, it was a leftover of my testing. |
I am sure we will merge this eventually, however since we're blocked on |
Oh that was quicker than expected, thanks! 😁 |
45cd5ed
to
1f94741
Compare
15efca8
to
c9c9e5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of #1485, all examples now compile on stable. I believe you're not using type_alias_impl_trait
so lets go ahead and remove it.
After that, I think think this is good to go! I got this running with my keyboard firmware and its working well, thanks for looking into this!
With this PR I have a better behaved debug probe than my priced-like-gold J-Link 😭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
* embassy-usb support * Add changelog entry * Update embassy-usb-synopsys-otg * Change VID/PID to match the blocking example * Add missing initialisation * Clean up * fmt * Remove log init * Use released crate * Revert to released embassy-usb * Update vid/pid * Remove redundant TAIT feature gate
Hey, @MabezDev I have been trying to get usb hid to work. I have used the embassy-usb raspberry pi example as a reference and have managed to make it work.
You mentioned you have a keyboard firmware so I was wandering if you knew how I should be adding report ids to the reports. |
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
CHANGELOG.md
in the proper section.Extra:
Pull Request Details 📖
Description
This PR uses the (as of yet unreleased)
embassy-usb-synopsys-otg
crate to implementembassy-usb
support for ESP32-S2 and ESP32-S3. The PR also adds an example, similar in functionality to the existingusb_serial
example.Resolves #1191
Testing
Ran the new example on an ESP32-S2-DevKitC-1 and ESP32-S3-DevKitC-1