Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-hal: rmt: make ChannelCreator public #1597

Merged
merged 6 commits into from
May 27, 2024

Conversation

liebman
Copy link
Contributor

@liebman liebman commented May 26, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

When using an Rmt channel you access rmt.channel0 to grab channel 0. However its type ChannelCreator<> is not public and can't be named as a function arg or struct member. This PR makes that public.

Testing

Compiled/Run in a local project where I add the rmt channels as struct members.

@liebman liebman marked this pull request as ready for review May 26, 2024 15:42
esp-hal/src/rmt.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessebraham
Copy link
Member

(Sorry I didn't mean to click that button, can't believe there's no confirmation, hopefully I didn't break anything 🤣)

Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

esp-hal/src/rmt.rs Outdated Show resolved Hide resolved
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jessebraham jessebraham enabled auto-merge May 27, 2024 16:07
@jessebraham jessebraham added this pull request to the merge queue May 27, 2024
Merged via the queue into esp-rs:main with commit e446d78 May 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants