Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esp-hal: rmt: make ChannelCreator public #1597

Merged
merged 6 commits into from
May 27, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions esp-hal/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- DMA transactions are now found in the `dma` module (#1550)
- Remove unnecessary generics from PARL_IO driver (#1545)
- Use `Level enum` in GPIO constructors instead of plain bools (#1574)
- rmt: make ChannelCreator public (#1597)

### Removed

Expand Down
10 changes: 9 additions & 1 deletion esp-hal/src/rmt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ pub struct RxChannelConfig {
pub idle_threshold: u16,
}

pub use impl_for_chip::Rmt;
pub use impl_for_chip::{ChannelCreator, Rmt};

#[cfg(feature = "async")]
use self::asynch::{RxChannelAsync, TxChannelAsync};
Expand Down Expand Up @@ -684,6 +684,8 @@ mod impl_for_chip {
}
}

/// RMT Channel Creator
#[allow(missing_docs)]
liebman marked this conversation as resolved.
Show resolved Hide resolved
jessebraham marked this conversation as resolved.
Show resolved Hide resolved
pub struct ChannelCreator<M, const CHANNEL: u8>
where
M: crate::Mode,
Expand Down Expand Up @@ -767,6 +769,8 @@ mod impl_for_chip {
}
}

/// RMT Channel Creator
#[allow(missing_docs)]
pub struct ChannelCreator<M, const CHANNEL: u8>
where
M: crate::Mode,
Expand Down Expand Up @@ -858,6 +862,8 @@ mod impl_for_chip {
}
}

/// RMT Channel Creator
#[allow(missing_docs)]
pub struct ChannelCreator<M, const CHANNEL: u8>
where
M: crate::Mode,
Expand Down Expand Up @@ -949,6 +955,8 @@ mod impl_for_chip {
}
}

/// RMT Channel Creator
#[allow(missing_docs)]
pub struct ChannelCreator<M, const CHANNEL: u8>
where
M: crate::Mode,
Expand Down
Loading