Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add I2S HIL test #1635

Merged
merged 4 commits into from
May 29, 2024
Merged

Add I2S HIL test #1635

merged 4 commits into from
May 29, 2024

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented May 29, 2024

ESP32 and ESP32-S2 are not tested since I wasn't able to get it to work there.

However, this test might be really helpful since it's the only test where circular DMA is tested. Also, I2S tends to be hard to test manually

@bjoernQ bjoernQ added the skip-changelog No changelog modification needed label May 29, 2024
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Regarding ESP32 and S2, it's i2s or hil related issue?

@bjoernQ
Copy link
Contributor Author

bjoernQ commented May 29, 2024

LGTM, thanks! Regarding ESP32 and S2, it's i2s or hil related issue?

I2S ... I wasn't able to get loopback working there. But since especially a lot of DMA code is shared it's still very helpful for those targets

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tried it on H2 and it passes, the only thing is that its a bit slow (~1 min):

      Erasing ✔ [00:00:00] [#] 192.00 KiB/192.00 KiB @ 520.69 KiB/s (eta 0s )
  Programming ✔ [00:00:00] [####] 37.88 KiB/37.88 KiB @ 67.90 KiB/s (eta 0s )    Finished in 0.954s

running 1 test
test tests::test_i2s_loopback ... ERROR probe_rs::util::rtt:
Error reading from RTT: The control block has been corrupted. write pointer is 2652638602 while buffer size is 1024 for up channel 0 (defmt)
ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 57.67s

@bjoernQ
Copy link
Contributor Author

bjoernQ commented May 29, 2024

Awesome .... the frequency on H2 is apparently so slow it takes forever to transmit the data. Will disable the test for H2 here and open an issue

@SergioGasquez
Copy link
Member

Awesome .... the frequency on H2 is apparently so slow it takes forever to transmit the data. Will disable the test for H2 here and open an issue

Feel free to add it here #1524 if you prefer

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernQ
Copy link
Contributor Author

bjoernQ commented May 29, 2024

For H2 see: #1637

@bjoernQ bjoernQ enabled auto-merge May 29, 2024 13:07
@bjoernQ bjoernQ added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@MabezDev
Copy link
Member

Sorry, let's just disable that interrupt test. I have no idea was is introducing the variability in the latency.

@MabezDev MabezDev enabled auto-merge May 29, 2024 13:47
@MabezDev MabezDev added this pull request to the merge queue May 29, 2024
Merged via the queue into esp-rs:main with commit 79d617d May 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants